fix(steering-odometry): convert twist to steering angle #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
erickisos,
mcbed,
olivier-stasse and
VX792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
+ Coverage 80.34% 80.36% +0.01%
==========================================
Files 105 105
Lines 9393 9391 -2
Branches 831 829 -2
==========================================
Hits 7547 7547
Misses 1570 1570
+ Partials 276 274 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Sep 12, 2024
christophfroehlich
added
backport-humble
bmagyar
approved these changes
Sep 25, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 50036e1)
mergify bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 50036e1)
This was referenced Sep 25, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 50036e1) Co-authored-by: Rein Appeldoorn <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 50036e1) Co-authored-by: Rein Appeldoorn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in this function was incorrect, if we divide by
0., the input of theatangoes toinfwhich should result inPI/2instead of0.. What should be handled instead arenanvalues as an input of theatanfunction that can happen if we input0./0..